Closed
Bug 462869
Opened 16 years ago
Closed 16 years ago
Firefox 3 silently fails to write downloaded files
Categories
(Toolkit :: Downloads API, defect)
Tracking
()
VERIFIED
DUPLICATE
of bug 429827
People
(Reporter: ofourdan, Unassigned)
Details
Attachments
(1 file)
707 bytes,
patch
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.0.3) Gecko/2008092416 Firefox/3.0.3 Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.0.3) Gecko/2008092416 Firefox/3.0.3 When saving a file to a non user writable directory, Firefox 3 give no notification to the user but an exception error in the log: There is no notification of failure to the user but a message in the console (if FF3 was started from a terminal): *** exception in validateLeafName: [Exception... "Component returned failure code: 0x80520015 (NS_ERROR_FILE_ACCESS_DENIED) [nsIFile.create]" nsresult: "0x80520015 (NS_ERROR_FILE_ACCESS_DENIED)" location: "JS frame :: file:///usr/lib/xulrunner-1.9/components/nsHelperAppDlg.js :: anonymous :: line 271" data: no] Reproducible: Always Steps to Reproduce: 1. Download a file 2. Use "Save to disk" instead of "Open with" 3. Select a destination directory that is not writable to the user Actual Results: There is no notification of failure to the user but a message in the console (if FF3 was started from a terminal): *** exception in validateLeafName: [Exception... "Component returned failure code: 0x80520015 (NS_ERROR_FILE_ACCESS_DENIED) [nsIFile.create]" nsresult: "0x80520015 (NS_ERROR_FILE_ACCESS_DENIED)" location: "JS frame :: file:///usr/lib/xulrunner-1.9/components/nsHelperAppDlg.js :: anonymous :: line 271" data: no] Expected Results: A dialog box notifying that the file was not saved. The fix is actually fairly simple, in "nsHelperAppDlg.js", the call to aLocalFile.create() must be protected by a try/catch.
Reporter | ||
Comment 1•16 years ago
|
||
Updated•16 years ago
|
Status: UNCONFIRMED → RESOLVED
Closed: 16 years ago
Resolution: --- → DUPLICATE
Updated•16 years ago
|
Status: RESOLVED → UNCONFIRMED
Resolution: DUPLICATE → ---
Updated•16 years ago
|
Status: UNCONFIRMED → NEW
Ever confirmed: true
Updated•16 years ago
|
Attachment #346056 -
Flags: review?(gavin.sharp)
Updated•16 years ago
|
Component: General → Download Manager
Product: Firefox → Toolkit
QA Contact: general → download.manager
Version: unspecified → Trunk
Comment 3•16 years ago
|
||
Bug 429827 should have fixed this.
Status: NEW → RESOLVED
Closed: 16 years ago → 16 years ago
Resolution: --- → DUPLICATE
Updated•16 years ago
|
Attachment #346056 -
Flags: review?(gavin.sharp)
Comment 4•16 years ago
|
||
Thanks for the patch anyways, though, Olivier!
You need to log in
before you can comment on or make changes to this bug.
Description
•